jeff/NSspi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improved the impersonation revert process.

Browse Source 
The Dispose(bool) method will still act even if finalizing, but it armors its access to the server to ensure that it doesn't accidentally cause a nullref trying to revert itself.
This commit is contained in:
Kevin Thompson
2019-06-16 16:57:23 -04:00
parent 4bd2ad0024
commit bbb7c7a060
1 changed files with 23 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
NSspi/Contexts/ImpersonationHandle.cs
View File

@@ -31,13 +31,16 @@ namespace NSspi.Contexts
this.disposed = false;
}
/// <summary>
/// Finalizes the ImpersonationHandle by reverting the impersonation.
/// </summary>
~ImpersonationHandle()
{
Dispose( false );
}
/// <summary>
/// Reverts the impersonation.
/// Reverts impersonation.
/// </summary>
public void Dispose()
{
@@ -45,11 +48,27 @@ namespace NSspi.Contexts
GC.SuppressFinalize( this );
}
protected virtual void Dispose( bool disposing )
/// <summary>
/// Reverts impersonation.
/// </summary>
/// <param name="disposing">True if being disposed, false if being finalized.</param>
private void Dispose( bool disposing )
{
if( disposing && this.disposed == false && this.server != null && this.server.Disposed == false )
// This implements a variant of the typical dispose pattern. Always try to revert
// impersonation, even if finalizing. Don't do anything if we're already reverted.
if( this.disposed == false )
{
this.server.RevertImpersonate();
this.disposed = true;
// Just in case the reference is being pulled out from under us, pull a stable copy
// of the reference while we're null-checking.
var serverCopy = this.server;
if( serverCopy != null && serverCopy.Disposed == false )
{
serverCopy.RevertImpersonate();
}
}
}
}